MCP Client Pool Dependency Injection Review

Reviewed and updated clientTools.ts and affordanceManager.ts to ensure that mcpClientPool dependency is passed directly instead of relying on global variables.

Removed:

• Global window interface declaration for mcpClientPool
• Optional mcpClientPool parameters in key functions

Updated:

• getAllAvailableTools(): Made mcpClientPool parameter required
• getAllToolHandlers(): Made mcpClientPool parameter required
• executeTool(): Made mcpClientPool parameter required
• jsExecHandler: Added proper null check for mcpClientPool before using
• getAffordanceManager(): Now requires mcpClientPool parameter and creates instance with it
• All affordance tool handlers: Added proper error handling when mcpClientPool is missing

Updated:

• Constructor: Added proper TypeScript typing for mcpClientPool parameter
• Added mcpClientPool as a private class property with proper typing
• registerAffordance(): Uses passed mcpClientPool or falls back to instance pool
• loadAndMountComponent(): Made mcpClientPool parameter required
• Removed global instance export (commented out with explanation)

Updated:

• buildBody(): Made clientPool parameter required
• executeToolCall(): Made clientPool parameter required
• useAnthropicStream(): Made clientPool parameter required
• All internal calls properly pass the clientPool parameter

1. No Global Dependencies: Eliminates reliance on global variables
2. Explicit Dependencies: All dependencies are explicitly passed through function parameters
3. Better Testability: Functions can be tested in isolation with mock dependencies
4. Type Safety: Proper TypeScript typing ensures compile-time error detection
5. Clearer API: Function signatures clearly indicate required dependencies

• All functions that need mcpClientPool now require it as a parameter
• No global variable access remains in the codebase
• Proper error handling when required dependencies are missing
• Type safety maintained throughout the dependency chain

// Before (using globals)
const tools = await getAllAvailableTools(); // Used window.mcpClientPool

// After (explicit dependency injection)
const tools = await getAllAvailableTools(mcpClientPool); // Explicit parameter

The codebase now follows proper dependency injection patterns with no reliance on global state.